fix: core modules are opened readonly

[nfischer]

Core modules (that get downloaded via URL) are now opened in readonly mode.

Fixes #30

[moll]

<3

You reckon you can throw in a test for it, too? Thanks!

[nfischer]

Sure! I'll take a look. Shouldn't be too hard.

Also, it looks like the CI failed, but it doesn't seem like it's due to my change. Perhaps it's a change in travis?

[moll]

Ugh, Travis. Why can't some things just remain as they are. -_- I'll get at it before merging. ;)

[nfischer]

I wrote out this test, and although it passes (when I uncomment it), it seems to have side effects that cause 3 other tests to fail:

  1) Failure:
Autoloaded::Goto file#test_0017_must find when filetype is JavaScript and file new [/home/nate/programming/forks/vim-node/test/autoload_test.rb:186]:
--- expected
+++ actual
@@ -1 +1 @@
-"/tmp/d20160112-17778-1ru217k/node_modules/foo/index.js"
+"/tmp/d20160112-17778-1ru217k/index.js"


  2) Failure:
Autoloaded::Goto file with split#test_0001_must edit file in a new split [/home/nate/programming/forks/vim-node/test/autoload_test.rb:270]:
Expected: "1"
  Actual: "0"

  3) Failure:
Autoloaded::Goto file with tab#test_0001_must edit file in a new tab [/home/nate/programming/forks/vim-node/test/autoload_test.rb:286]:
Expected: "1"
  Actual: "0"

Any idea what the side effect could be, @moll? The other tests start passing if I uncomment the Nedit fs line.

[nfischer]

Update: I realized the issue was I forget setlocal (readonly is local by default, modifiable is however not). I added the other test back in, and it all passes the unit tests for me (so this should be good to merge, once the CI is fixed).

I tried a couple things for travis, but couldn't figure out a solution. I'll open another issue for it and post what I had.

[moll]

Hey, why'd you close it?

[nfischer]

I don't intend to continue working on this PR. You may land a similar patch if you're interested. Thanks for an excellent plugin 🎉