Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds dynamic calculation of the reimbursable amount #61

Merged
merged 8 commits into from
Feb 25, 2022
Merged

Adds dynamic calculation of the reimbursable amount #61

merged 8 commits into from
Feb 25, 2022

Conversation

sandervanhooft
Copy link
Collaborator

@sandervanhooft sandervanhooft commented Feb 24, 2022 •
edited

Instead of simply calculating the reimbursable amount based on the former subscription plan, this PR calculates the reimbursable amount dynamically by:

  • taking the most recently paid subscription order item
  • minus any refunds applied to that order item
  • and minus any coupons applied to that order item

@sandervanhooft sandervanhooft mentioned this pull request Feb 25, 2022
Closed
@sandervanhooft sandervanhooft linked an issue Feb 25, 2022 that may be closed by this pull request
User is credited for full plan value on swap instead of firstPaymentAmount #35
Closed
@sandervanhooft sandervanhooft merged commit c17e7d7 into mollie:main Feb 25, 2022
@sandervanhooft sandervanhooft deleted the reimbursable_amount branch February 25, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User is credited for full plan value on swap instead of firstPaymentAmount
1 participant
@sandervanhooft