Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Unified Push as Push Provider #88

Closed
1 task done
schnuppikarotti opened this issue Jan 20, 2022 · 15 comments
Closed
1 task done

Use Unified Push as Push Provider #88

schnuppikarotti opened this issue Jan 20, 2022 · 15 comments
Labels
feature-request New feature or request

Comments

@schnuppikarotti
Copy link

schnuppikarotti commented Jan 20, 2022

Is there an existing request for this?

  • I have searched the existing issues

Feature description

Would be a nice feature for the FOSS-Version to Support https://unifiedpush.org

@Ammako
Copy link

Ammako commented Oct 27, 2022

Consider #74

This is something that upstream would have to do, I'm afraid.

Also UnifiedPush/wishlist#8 for more

Unfortunately I don't see it happening any time soon :/

signalapp/Signal-Android#12490
signalapp/Signal-Android#9729 (comment)

@p1gp1g
Copy link
Member

p1gp1g commented Nov 20, 2022

FYI, I am using molly with UnifiedPush for a month now. It requires a software running on a server. (The server does not have any crypto key, so the encryption is not broken)

I will give more details, publish the server code and open a PR for Molly as soon as it is ready for testing. Then some testers will be very welcome. Also that the first time I write some rust, any rust reviewer will be welcome too :)

@genofire
Copy link

hmm, have not write much in rust and have not much time.

I will host an server (in my k8s), after i build an container and helmchart.

@ilikenwf
Copy link

FYI, I am using molly with UnifiedPush for a month now. It requires a software running on a server. (The server does not have any crypto key, so the encryption is not broken)

I will give more details, publish the server code and open a PR for Molly as soon as it is ready for testing. Then some testers will be very welcome. Also that the first time I write some rust, any rust reviewer will be welcome too :)

Any news on this? Sounds interesting and a lot less convoluted than using Matrix...

@p1gp1g
Copy link
Member

p1gp1g commented Nov 29, 2022

It can now (*) begin to be reviewed and tested. It still misses a few things (like replacing the shared preferences by the internal store, implementing alerts for edge cases for a specific setup and adding readmes) but this can be done during the tests and review.

(*) I will very probably publish everything this week

@ilikenwf
Copy link

Very cool!

Have you done any battery benchmarking between push vs websocket?

@p1gp1g
Copy link
Member

p1gp1g commented Nov 29, 2022

Not really, I do not have a lot of contact on Signal so it is not very relevant. Also, I have only tested one of the 2 fetch strategies implemented. That's why testers are very welcomed: we should compare the battery consumption with the 2 strategies and without UnifiedPush (with FCM or with the websocket).

@p1gp1g p1gp1g mentioned this issue Dec 1, 2022
5 tasks
@p1gp1g
Copy link
Member

p1gp1g commented Dec 1, 2022

The PR is now opened and I've published the server code.

@mpelley92
Copy link

Just wondering if there has been any progress with this in the past 3 months. I'm using Molly FOSS due to having no Google Play framework and it easily pulls 20% a day from my usage just for notifications. Would be pretty awesome to have Unified Push implemented on the server side of Signal (if anyone here has any influence there) and then supported by Molly.

Thanks for everyone involved in the testing process.

@julianfoad
Copy link

Just a note that activity on this is taking place in the linked merge request #152 . We can follow it there. (Hurray!)

@valldrac
Copy link
Member

This is already done. Officially supported since version 6.35.3-1.

@ilikenwf
Copy link

This is already done. Officially supported since version 6.35.3-1.

Oh so it's in the mainline apk now? The wiki/readmes need updated to indicate this if possible as they still imply there are separate builds for it on fdroid.

@valldrac
Copy link
Member

Oh so it's in the mainline apk now?

Not yet. But it's fully supported with the separate apk in https://github.com/mollyim/mollyim-android-unifiedpush. We'll have it all in one app at some point.

Just found this old ticket and closed it.

@ilikenwf
Copy link

I switched back to molly recently, just with websockets...while bat usage is higher I was sick of gsf under graphene.

@valldrac
Copy link
Member

I switched back to molly recently, just with websockets...while bat usage is higher I was sick of gsf under graphene.

We made some improvements to reduce battery drain in the latest update: https://fosstodon.org/@mollyim/111816064499180353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Development

No branches or pull requests

8 participants