Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement draft11 #19

Merged
merged 1 commit into from Apr 21, 2014
Merged

Implement draft11 #19

merged 1 commit into from Apr 21, 2014

Conversation

nwgh
Copy link
Collaborator

@nwgh nwgh commented Apr 18, 2014

Here's the protocol-level implementation of draft11. All tests pass, new tests have been added where appropriate.

The one major change I didn't do is actually implementing the priority scheme on the connection (in other words, actually prioritizing streams). I felt that was an OK tradeoff to make, since the new prioritization scheme is still in flux, and all priorities are advisory, anyway :) Once we get prioritization more locked-in in the spec, I'll fix up the implementation of prioritization. Right now, this just means that all streams will have the same priority (or one less, for pushed streams).

I'll also be sending a PR to node-http2 to update the version of the protocol library used.

molnarg pushed a commit that referenced this pull request Apr 21, 2014
@molnarg molnarg merged commit 64038f6 into molnarg:master Apr 21, 2014
@molnarg
Copy link
Owner

molnarg commented Apr 21, 2014

Thanks, you are the best! The actual prioritization is something that was quite tricky get right back in the summer because of dealing with the Stream class internals, etc. Leave it to me, I'll take care of it when things calm down (maybe the next draft?), this is not critical for Firefox testing right? This time I'll really try to allocate some time to it!

@nwgh
Copy link
Collaborator Author

nwgh commented Apr 21, 2014

Thanks! I try to be helpful :) Prioritization is in no way critical for Firefox testing at this point. Perhaps, if we at some time in the future, try to write performance tests, it might become critical for Firefox testing, but given that all PRIORITY frames are advisory, we can't rely on any server doing what we want, anyway.

If I get to draft12 before you, I'll just focus on the protocol bits and leave priority for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants