allow receipt of PRIORITY in idle state #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spec 5.1 Stream States -> idle "Receiving any frames other than HEADERS, PUSH_PROMISE or PRIORITY on a stream in this state MUST be treated as a connection error (Section 5.4.1) of type PROTOCOL_ERROR." This is useful for creating dependency grouping nodes in the priority dependency tree - the group nodes are streams that may never opened. section 5.3.4 "Similarly, streams that are in the "idle" state can be assigned priority or become a parent of other streams. This allows for the creation of a grouping node in the dependency tree, which enables more flexible expressions of priority. Idle streams that are made a parent of another stream are assigned a default priority (Section 5.3.5)."
|
As discussed on IRC - this causes CI to fail, because the test needs updating, too. I'll fix up the test (pretty simple to do) and merge this + my fix. |
|
This is now happening over in #91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec 5.1 Stream States -> idle "Receiving any frames other than
HEADERS, PUSH_PROMISE or PRIORITY on a stream in this state MUST
be treated as a connection error (Section 5.4.1) of type PROTOCOL_ERROR."
This is useful for creating dependency grouping nodes in the priority
dependency tree - the group nodes are streams that may never opened.
section 5.3.4 "Similarly, streams that are in the "idle" state can be assigned
priority or become a parent of other streams. This allows for the
creation of a grouping node in the dependency tree, which enables
more flexible expressions of priority. Idle streams that are made
a parent of another stream are assigned a default priority
(Section 5.3.5)."