Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dicom Anonymizer #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Dicom Anonymizer #4

wants to merge 3 commits into from

Conversation

ssikka
Copy link

@ssikka ssikka commented Nov 17, 2012

The code is barely documented and does not entirely conform to pep8.

I see this pull request as a chance to continue working on the documentation and code standards until everyone is satisfied.

@moloney
Copy link
Owner

moloney commented Nov 27, 2012

Thanks for the hard work!

I haven't looked in too much detail, but I have a couple of questions:

  1. Where do you see this integrating with dcmstack? It looks like you need to work with the original DICOM data set, not the extracted meta data. This would mean you would need to integrate this with a MetaExtractor object of some kind.

  2. What about meta data from private elements? Are you always just going to discard all private elements?

@moloney
Copy link
Owner

moloney commented Mar 1, 2013

Hi. It seems like you should be able to specify and ignore_rule to integrate this with the existing MetaExtractor object. Check out the examples "ignore_private" and "ignore_non_ascii_bytes" in the dcmstack.extract module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants