Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwdpp fails internal tests. New gsl. #51

Closed
tmozgach opened this issue Jun 28, 2017 · 5 comments
Closed

fwdpp fails internal tests. New gsl. #51

tmozgach opened this issue Jun 28, 2017 · 5 comments

Comments

@tmozgach
Copy link

tmozgach commented Jun 28, 2017

https://github.com/Homebrew/homebrew-science/pull/5859
Hello,
gsl was recently updated and now brew install fwdpp -s fails.

There is a log:

=========================================

Running 31 test cases...
integration/sugar_matrixTest.cc(236): fatal error: in "singlepop_hapmatrix_GSL_behavior": critical check v.matrix.size1 == 0 has failed [260 != 0]

*** 1 failure is detected in the test module "sugar_integration_tests" ```
 
@molpopgen
Copy link
Owner

molpopgen commented Jun 29, 2017 via email

@tmozgach
Copy link
Author

@molpopgen gsl 2.4.

@molpopgen
Copy link
Owner

OK, I can confirm on OS X. I'll look into it. In the mean time, you may want to pin the required version at whatever worked before.

@molpopgen
Copy link
Owner

@tmozgach The test that is failing is checking if GSL raises a signal when trying to construct a matrix view from empty data. GSL <= 2.0 do indeed raise an exception. 2.4 does not, and I don't know where the change was introduced. I will peek at the GSL source code, but will probably simply remove the failing test from the fwdpp testing suite. This change will make it into 0.5.6, which is currently the dev branch on github, and is overdue for a release anyways.

@molpopgen
Copy link
Owner

Closing--fixed with release of 0.5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants