Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional models use incorrect procedure to pick branches #1019

Closed
molpopgen opened this issue Nov 3, 2022 · 0 comments
Closed

Conditional models use incorrect procedure to pick branches #1019

molpopgen opened this issue Nov 3, 2022 · 0 comments
Labels
bug
Milestone
0.19.0

Comments

@molpopgen
Copy link
Owner

The current logic to find a branch to place a mutation is:

  1. Find all branches that satisfy the desired criteria.
  2. Choose one of those branches uniformly at random.

This procedure is incorrect -- the choice should be made proportionally to each branch's length.
@molpopgen molpopgen added the bug label Nov 3, 2022
@molpopgen molpopgen added this to the 0.19.0 milestone Nov 4, 2022
@molpopgen molpopgen mentioned this issue Nov 6, 2022
Merged
@molpopgen molpopgen mentioned this issue Nov 8, 2022
Merged
molpopgen added a commit that referenced this issue Nov 8, 2022
@molpopgen
Another fix for branch choice in conditional models.
b10c56e 
* Choose by length*span.
* This was missed in PR #1020
* See issue #1019
molpopgen added a commit that referenced this issue Nov 8, 2022
@molpopgen
Another fix for branch choice in conditional models. (#1026)
5d75e0b 
* Choose by length*span.
* This was missed in PR #1020
* See issue #1019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.19.0
Development

No branches or pull requests
1 participant
@molpopgen