You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When there are multiple branches satisfying the desired frequency criterion,
we currently sample from those branches proportionally to their length.
This procedure is likely biased.
For a desired interval [a,b), the weight placed on a branch overlapping
that interval should be length*(min(b,right)-max(a,left)).
(This procedure is implemented in cpp/functions/add_mutation.cc.)
The text was updated successfully, but these errors were encountered:
So, #1026 already picked a branch from a tree according to length*(tree span).
But that is not quite right. If the desired range is smaller than the tree span, or only partially overlaps it, then we are off by not accounting for the overlap.
When there are multiple branches satisfying the desired frequency criterion,
we currently sample from those branches proportionally to their length.
This procedure is likely biased.
For a desired interval
[a,b)
, the weight placed on a branch overlappingthat interval should be
length*(min(b,right)-max(a,left))
.(This procedure is implemented in cpp/functions/add_mutation.cc.)
The text was updated successfully, but these errors were encountered: