Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit GSL error handling. #143

Closed
molpopgen opened this issue Nov 6, 2018 · 1 comment
Closed

Revisit GSL error handling. #143

molpopgen opened this issue Nov 6, 2018 · 1 comment
Milestone

Comments

@molpopgen
Copy link
Owner

molpopgen commented Nov 6, 2018

#101 introduced an "init" module that promotes GSL errors to C++ exceptions. This approach works well when fwdpy11 is the only module using GSL. However, this behavior conflicts with msprime, which disables all GSL error handling (see tskit-dev/msprime#632).

A preferable behavior may be scoped unsetting of the global handler, resetting upon exit. We already have the classes in place to do this.

@molpopgen molpopgen added this to To do in C++ back end via automation Apr 5, 2020
@molpopgen
Copy link
Owner Author

py::call_guard may be the way to go here. Instead of trying to handle things globally upon import, we can do it on a case-by-case-basis.

molpopgen added a commit that referenced this issue Aug 13, 2020
Add GSLError exception class.

Closes #143
molpopgen added a commit that referenced this issue Aug 13, 2020
Add GSLError exception class.

Closes #143
@molpopgen molpopgen added this to the 0.10.0 milestone Oct 27, 2020
C++ back end automation moved this from To do to Done Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
C++ back end
  
Done
Development

No branches or pull requests

1 participant