Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of "ancient sample resetting"? #644

Closed
molpopgen opened this issue Jan 22, 2021 · 1 comment
Closed

Improve performance of "ancient sample resetting"? #644

molpopgen opened this issue Jan 22, 2021 · 1 comment
Labels
performance tree sequences

Comments

@molpopgen
Copy link
Owner

The fix for #639 introduced in #643 forces the simulation to count mutations. For a lot of ancient samples, this is expensive. The counting is also not necessary. Strictly-speaking, all that is needed is to index the tables. This issue is a reminder to look into this in the future.
@molpopgen
Copy link
Owner Author

This is such a rare use case that we can close this for now.
We can reopen if anyone feels there is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance tree sequences
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen