Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An experimental feature needs better testing #639

Closed
molpopgen opened this issue Jan 19, 2021 · 1 comment · Fixed by #643, #647 or #650
Closed

An experimental feature needs better testing #639

molpopgen opened this issue Jan 19, 2021 · 1 comment · Fixed by #643, #647 or #650
Labels
bug tree sequences
Milestone
0.13.0

Comments

@molpopgen
Copy link
Owner

It seems that the post_simplification_recorder idea is a bit flaky. It definitely needs more tests, and a better clarification of what it does and if there are any cases where it shouldn't work. There's likely a bug in there somewhere.
@molpopgen
Copy link
Owner Author

The current test of this feature does a lot of the ops that we care about. Simply adding neutral mutations to it during the sim causes an exception to raise. There's a good chance this is a bug.

@molpopgen molpopgen mentioned this issue Jan 20, 2021
Merged
molpopgen added a commit that referenced this issue Jan 21, 2021
@molpopgen
Add test of ancient sample resetting with neutral mutations.
cf3b2d2 
Closes #639
@molpopgen molpopgen added this to the 0.13.0 milestone Jan 21, 2021
@molpopgen molpopgen mentioned this issue Jan 22, 2021
Closed
molpopgen added a commit that referenced this issue Jan 23, 2021
@molpopgen
Merge pull request #643 from molpopgen/fix_experimental_feature
79d535a 
Partial fix for error when using "ancient sample" resetting in sims with neutral mutations.
(See #639)
@molpopgen molpopgen linked a pull request Jan 23, 2021 that will close this issue
Fix error when using "ancient sample" resetting in sims with neutral mutations. #643
Merged
@molpopgen molpopgen mentioned this issue Jan 23, 2021
Closed
molpopgen added a commit that referenced this issue Jan 23, 2021
@molpopgen
candidate fix for #639
a7e6149
@molpopgen molpopgen mentioned this issue Jan 23, 2021
Merged
1 task
molpopgen added a commit that referenced this issue Jan 23, 2021
@molpopgen
candidate fix for #639
dc1a43b
molpopgen added a commit that referenced this issue Jan 24, 2021
@molpopgen
candidate fix for #639
a50439a
molpopgen added a commit that referenced this issue Jan 24, 2021
@molpopgen
Add tests for Issues #639 and #646
6d0989c
molpopgen added a commit that referenced this issue Jan 24, 2021
@molpopgen
candidate fix for #639
93e7aac
molpopgen added a commit that referenced this issue Jan 24, 2021
@molpopgen
Add tests for Issues #639 and #646
1fcbaac
molpopgen added a commit that referenced this issue Jan 24, 2021
@molpopgen
candidate fix for #639
a7abc47
@molpopgen molpopgen linked a pull request Feb 8, 2021 that will close this issue
Add check on container sizes at end of final_population_cleanup. #650
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tree sequences
Projects
None yet
Milestone
0.13.0
1 participant
@molpopgen