Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conditional_models.GlobalFixation incorrectly handles mutation key changes #893

Closed
molpopgen opened this issue Jan 11, 2022 · 0 comments
Closed

conditional_models.GlobalFixation incorrectly handles mutation key changes #893

molpopgen opened this issue Jan 11, 2022 · 0 comments
Labels
bug

Comments

@molpopgen
Copy link
Owner

If the "key" has changed, we should be checking the fixation array to see if the variant fixed. If it fixed, exit. Right now, we incorrectly return and continue evolving w/o checking the fixations.

        if pop.mutations[index].key != key:
            return SimulationStatus(False, False)
@molpopgen molpopgen added the bug label Jan 11, 2022
molpopgen added a commit that referenced this issue Jan 11, 2022
@molpopgen
Fix logic in GlobalFixation and FocalDemeFixation
61b428f 
for cases where the mutation key has changed.

Fixes #893
@molpopgen molpopgen mentioned this issue Jan 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen