Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit use of gsl_ran_flat. #903

Closed
molpopgen opened this issue Feb 10, 2022 · 2 comments
Closed

Audit use of gsl_ran_flat. #903

molpopgen opened this issue Feb 10, 2022 · 2 comments
Labels
C++ back end upstream (fwdpp)
Milestone
0.19.0

Comments

@molpopgen
Copy link
Owner

As discovered in tskit-dev/msprime#1997, this GSL function has a rare bug.

The solution has to come from upstream, via fwdpp, as the function is also widely-used there.
@molpopgen
Copy link
Owner Author

See molpopgen/fwdpp#354

@molpopgen
Copy link
Owner Author

Fortunately, there are relatively few calls to this.
Adding it to the 0.19.0 milestone

@molpopgen molpopgen added this to the 0.19.0 milestone Nov 10, 2022
@molpopgen molpopgen mentioned this issue Nov 11, 2022
Merged
molpopgen added a commit that referenced this issue Nov 11, 2022
@molpopgen
add safety check to gsl_ran_flat.
130d3fa 
Closes #903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ back end upstream (fwdpp)
Projects
None yet
Milestone
0.19.0
Development

No branches or pull requests
1 participant
@molpopgen