Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ back ends of regions should be able to validate their [beg, end). #910

Closed
molpopgen opened this issue Mar 10, 2022 · 0 comments
Closed

C++ back ends of regions should be able to validate their [beg, end). #910

molpopgen opened this issue Mar 10, 2022 · 0 comments
Labels
C++ back end

Comments

@molpopgen
Copy link
Owner

Following up on #908, it would be nice if the C++ side of these objects could be used to validate that they don't fall outside of the genome length. Doing so requires some plumbing, like a new pure virtual function that all derived classes need to implement.
molpopgen added a commit that referenced this issue Sep 23, 2022
@molpopgen
Add Python check that regions don't extend past genome length.
7467f12 
See issues #910 and #908.
This is not a fix for those issues,
which would require that the validation
happen on the C++ side.
@molpopgen molpopgen mentioned this issue Sep 23, 2022
Merged
molpopgen added a commit that referenced this issue Sep 23, 2022
@molpopgen
Add Python check that regions don't extend past genome length. (#987)
cf8a59a 
See issues #910 and #908.
This is not a fix for those issues,
which would require that the validation
happen on the C++ side.
molpopgen added a commit that referenced this issue Oct 5, 2022
@molpopgen
Add Python check that regions don't extend past genome length. (#987)
8e14e59 
See issues #910 and #908.
This is not a fix for those issues,
which would require that the validation
happen on the C++ side.
@molpopgen molpopgen mentioned this issue Nov 10, 2022
Merged
molpopgen added a commit that referenced this issue Nov 10, 2022
@molpopgen
C++ back end of Region/Sregion now validated beg/end at start of sim.
f5460a1 
* The genetic map objects cannot do this.
  Type erasure is at work here and access to start/stop
  is not part of the API.
  Fixing this requires changes to upstream (fwdpp).

Closes #910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C++ back end
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen