Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin in examples/ may need updating to latest pybind11? #920

Closed
molpopgen opened this issue Apr 2, 2022 · 2 comments
Closed

Plugin in examples/ may need updating to latest pybind11? #920

molpopgen opened this issue Apr 2, 2022 · 2 comments
Labels
pybind11

Comments

@molpopgen
Copy link
Owner

The plugin is failing to compile with pybind11 2.9.2 over in #823.

Also, it is not being compiled in the Ubuntu tests work flow.
@molpopgen
Copy link
Owner Author

The problem seems to be the lambda capture: [l] is being interpreted as capturing a const variable, rather than a non-const copy of the input variable. Replacing with [&l] on Ubuntu with pybind11 2.9.1 seems to fix the issue.

@molpopgen molpopgen mentioned this issue Apr 3, 2022
Merged
@molpopgen
Copy link
Owner Author

The fix is not as simple as stated above. Something seems to have changed re: binding python objects
.

molpopgen added a commit that referenced this issue Apr 3, 2022
@molpopgen
Change lambda capture to capture-by-reference in example plugin.
838a90e 
Build and run example plugin during Ubuntu "stress test" CI.

Closes #920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pybind11
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen