Track down conditional_models bug #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molpopgen
force-pushed
the
conditional_models_bug
branch
from
9e82ad6
to
4019750
Compare
When the "ancient sample policy" was DURATION, we were erroneously making a call to record ancient samples prior to the start of a simulation. This procedure violates internal data model expectations and triggered the internal exception seen. Fixes #1093
molpopgen
force-pushed
the
conditional_models_bug
branch
from
4019750
to
ed34d99
Compare
molpopgen
added a commit
that referenced
this pull request
Mar 10, 2023
molpopgen
added a commit
that referenced
this pull request
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1093