Warn when prune_selected = True can be a problem #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
molpopgen
commented
Nov 13, 2023
molpopgen
commented
- Add failing test
- Add fwdpy11.PruneSeletedWarning
- add the validator to ModelParams
- write post-init validator and some simple tests
- remove validator -- this has to be post-init
- refactor to handle gvalue lists
- fix one test
molpopgen
force-pushed
the
prune_selected_warning
branch
from
4e2c3c7
to
4504bad
Compare
* Add fwdpy11.PruneSeletedWarning * Raise warning from ModelParams * Fix tests, manual example, and examples/ that raise the warning * Add gvalue_to_fitness and noise attributes to PyDiploidGeneticValue Closes #1232
molpopgen
force-pushed
the
prune_selected_warning
branch
from
76b065f
to
92f52c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.