Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero effect size bug #433

Merged
merged 8 commits into from Mar 28, 2020
Merged

Fix zero effect size bug #433

merged 8 commits into from Mar 28, 2020

Conversation

molpopgen
Copy link
Owner

Fixes #432

that the mutation is neutral or not.  NOTE: the tuple-based
constructors do not require this, but they will be deprecated
soon anyways.
Added a new source file to preserve backwards compatibility with
files generated from earlier versions.
* Throws an exception from the constructor expost to Python if effect size is zero.
* Has a new constructor not exposed to Python that still allows this
  type to generate new mutations when neutral variants are added to tree
  sequences during a simulation.
* Update operator() to match new infsites_Mutation API.
* Update pickling code to reflect the new constructors.
constructor for generating variants from "nregions".
@molpopgen molpopgen added the bug label Mar 26, 2020
@molpopgen molpopgen added this to the 0.6.3 milestone Mar 26, 2020
@molpopgen molpopgen linked an issue Mar 26, 2020 that may be closed by this pull request
@molpopgen molpopgen merged commit d6a70b2 into dev Mar 28, 2020
@molpopgen molpopgen mentioned this pull request Mar 28, 2020
@molpopgen molpopgen deleted the fix_zero_effect_size_bug branch April 1, 2020 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problematic handling of "zero"
1 participant