Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TreeIterator #678

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Refactor TreeIterator #678

merged 2 commits into from
Mar 1, 2021

Commits on Mar 1, 2021

  1. C++ TreeIterator class now holds shared_ptr instead of py::object 

    to keep a reference to the input tables.
    @molpopgen
    molpopgen committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    99380d2 View commit details
    Browse the repository at this point in the history

  2. Refactor the C++ TreeIterator class as ll_TreeIterator. 

    Add Python TreeIterator class inheriting from ll_TreeIterator.
API changes:
1. .nodes() no longer needs arguments
2. init methods now use more kwargs instead of all positional args.
    @molpopgen
    molpopgen committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    cab247c View commit details
    Browse the repository at this point in the history