Demes import #710
Merged
Demes import #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molpopgen
reviewed
Apr 1, 2021
| @@ -0,0 +1,24 @@ | |||
| description: Two deme model with migration and size changes. | |||
There was a problem hiding this comment.
It'd be very cool if demes made its own examples available as package data.
There was a problem hiding this comment.
I agree - should open an issue for that over in the demes repo
There was a problem hiding this comment.
There are some examples perhaps, now that I think of it. I can see if there are and try to use some of those instead of having the example yaml file here.
There was a problem hiding this comment.
Yeah, I'm just not sure they go in via "pip install".
|
This looks great. Just a few comments. |
molpopgen
reviewed
Apr 1, 2021
molpopgen
reviewed
Apr 1, 2021
| @@ -535,3 +525,16 @@ def _timed_events(self): | |||
| self.set_migration_rates, | |||
| ]: | |||
| yield i | |||
|
|
|||
|
|
|||
| def from_demes( | |||
There was a problem hiding this comment.
Let's get the "versionadded" bit here, too, as this is the user-facing function.
|
Awesome--thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First steps to get demes into fwdpy11, updated from the previous
demes2fwdpy11repo.