Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with pybind11 2.10.0 #986

Merged
merged 1 commit into from Sep 23, 2022
Merged

Fix compatibility with pybind11 2.10.0 #986

merged 1 commit into from Sep 23, 2022

Conversation

molpopgen
Copy link
Owner

@molpopgen molpopgen commented Sep 22, 2022 •
edited

  • Add asserts to hit Possible issue with pybind11 2.10 #954 without triggering segfault
  • Fixes for py::make_iterator.
  • bump to pybind11 2.10.0 in pyproject.toml
  • Bump to pybind11 2.10.0 in requirements/development.txt
  • bump to pybind11 2.10.0 in conda/conda_minimal_deps.txt
  • CMakeLists.txt now enforces pybind11 2.10.0 or later

@molpopgen molpopgen force-pushed the pybind11_2_10 branch 2 times, most recently from 803cae5 to 22dde32 Compare September 23, 2022 12:49
@molpopgen
Bump pybind11 to 2.10.0
3710767 
Fixes for py::make_iterator:

* Add asserts to hit #954 without triggering segfault
  in Python tests
* Add runtime checks of internal iterator validity.
* Use std::move for py::make_iterator.
  This is required for pybind11 2.10 so that we don't
  segfault.
* See GitHub issue #954

Closes #954
@molpopgen molpopgen merged commit e6a46b1 into dev Sep 23, 2022
@molpopgen molpopgen deleted the pybind11_2_10 branch September 23, 2022 15:34
molpopgen added a commit that referenced this pull request Oct 5, 2022
@molpopgen
Bump pybind11 to 2.10.0 (#986)
2bb0e9c 
Fixes for py::make_iterator:

* Add asserts to hit #954 without triggering segfault
  in Python tests
* Add runtime checks of internal iterator validity.
* Use std::move for py::make_iterator.
  This is required for pybind11 2.10 so that we don't
  segfault.
* See GitHub issue #954

Closes #954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@molpopgen