Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contexts #9

Merged
merged 8 commits into from Nov 17, 2020
Merged

Contexts #9

merged 8 commits into from Nov 17, 2020

Conversation

StefanGsi
Copy link
Contributor

Create editor for collection based parameters

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #9 (ea2140b) into master (d14c5bf) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #9      +/-   ##
===========================================
- Coverage      1.35%   1.31%   -0.05%     
  Complexity        4       4              
===========================================
  Files            38      41       +3     
  Lines           959     989      +30     
  Branches         64      68       +4     
===========================================
  Hits             13      13              
- Misses          942     972      +30     
  Partials          4       4              
Impacted Files Coverage Δ Complexity Δ
...ui/fx/app/LocalRunnableLeafsMoleConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...rc/main/java/io/molr/gui/fx/app/MolrFxGuiMain.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...va/io/molr/gui/fx/app/RemoteMoleConfiguration.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../main/java/io/molr/gui/fx/widgets/MissionPane.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../main/java/io/molr/gui/fx/widgets/MissionView.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...n/java/io/molr/gui/fx/widgets/ParameterEditor.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14c5bf...ea2140b. Read the comment docs.

@StefanGsi StefanGsi requested a review from kaifox November 9, 2020 14:06
Copy link
Member

@kaifox kaifox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problem in merging this.

@StefanGsi StefanGsi merged commit f55ccdf into master Nov 17, 2020
@StefanGsi StefanGsi deleted the contexts branch November 17, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants