Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Put buttons on toolbar #36

Closed
MDagni opened this issue Jun 18, 2023 · 8 comments · Fixed by notepad-plus-plus/nppPluginList#719
Closed

Feature request: Put buttons on toolbar #36

MDagni opened this issue Jun 18, 2023 · 8 comments · Fixed by notepad-plus-plus/nppPluginList#719
Labels
enhancement New feature or request probably fixed? the issue/feature appears to be fixed/implemented, but there still may be issues

Comments

@MDagni
Copy link

MDagni commented Jun 18, 2023

It would be really nice to have buttons for commands on the toolbar. I especially need "Pretty-print current JSON file" and "Path to current line".
Thanks.

@molsonkiko
Copy link
Owner

Seems like a good idea. I generally prefer using the accelerator keys (Alt-P-J-P (as a sequence, not holding Alt down) for pretty-print and Alt-P-J-O for path to current line, but I'll add toolbar buttons in the next release.

@molsonkiko molsonkiko added the enhancement New feature or request label Jun 20, 2023
molsonkiko added a commit that referenced this issue Aug 24, 2023
Address issue #36.
add toolbar icons for prettyprint, path to position, compress, tree view
@molsonkiko molsonkiko added the probably fixed? the issue/feature appears to be fixed/implemented, but there still may be issues label Aug 24, 2023
@molsonkiko
Copy link
Owner

as of next release, should be fixed

@molsonkiko
Copy link
Owner

One thing I've observed in playing around with this is that sometimes the icons disappear when going from light mode to dark mode (but not vice versa). This is only temporary; when you restart Notepad++ in dark mode or light mode the icons are all there.

If you or anyone else happen to notice a clear pattern of usage that makes the icons more likely to disappear, please let me know and I'll try to fix it.

@MDagni
Copy link
Author

MDagni commented Aug 28, 2023

How can I test this? Release 5.6 doesn't have the icons.

@molsonkiko
Copy link
Owner

If you want to test it now, and not wait until the next release (which I would recommend), you can download a build with icons here (choose plugin_dll_x64 for 64bit NPP or plugin_dll_x86 for 32bit), extract JsonTools.dll from the zip file, and replace JsonTools.dll in the plugins folder with this version.

Generally speaking, you can get GitHub Actions builds like this one by following these instructions.

@MDagni
Copy link
Author

MDagni commented Aug 28, 2023

I believe I will just wait :)

@molsonkiko
Copy link
Owner

New release with toolbar icons just came out.

@molsonkiko
Copy link
Owner

I'm going to close this, although issue #53 is a known lingering issue with the toolbar icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request probably fixed? the issue/feature appears to be fixed/implemented, but there still may be issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants