Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling errors within the steps in the loop #18

Merged
merged 12 commits into from
Dec 12, 2021
Merged

Handling errors within the steps in the loop #18

merged 12 commits into from
Dec 12, 2021

Conversation

paulsaxe
Copy link
Contributor

Also added filtering the rows of tables, closes #17

@paulsaxe paulsaxe added the enhancement New feature or request label Dec 12, 2021
@paulsaxe paulsaxe requested a review from seamm December 12, 2021 22:18
@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #18 (048cbb5) into main (847da7f) will decrease coverage by 4.07%.
The diff coverage is 5.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   19.70%   15.63%   -4.08%     
==========================================
  Files           4        4              
  Lines         274      403     +129     
==========================================
+ Hits           54       63       +9     
- Misses        220      340     +120     
Flag Coverage Δ
unittests 15.63% <5.10%> (-4.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
loop_step/loop_parameters.py 87.50% <0.00%> (ø)
loop_step/loop_step.py 66.66% <ø> (ø)
loop_step/loop.py 9.70% <4.07%> (-1.46%) ⬇️
loop_step/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 847da7f...048cbb5. Read the comment docs.

Copy link
Contributor

@seamm seamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I blieve these are OK; however, black has changed a lot making it difficult to see.

@seamm seamm merged commit 326ce49 into main Dec 12, 2021
@seamm seamm deleted the catch_errors branch December 12, 2021 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip rows meeting given criteria
2 participants