Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Residue rainbow coloring pdb format #72

Closed
bioinsilico opened this issue Jul 17, 2020 · 5 comments
Closed

Residue rainbow coloring pdb format #72

bioinsilico opened this issue Jul 17, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@bioinsilico
Copy link

bioinsilico commented Jul 17, 2020

Residue rainbow coloring does not behave as expected when N-terminal residue numbering starts at large indexes in pdb format files. In the attached file the full ribbon is displayed in red

101M.pdb.zip

@arose arose added the bug Something isn't working label Jul 18, 2020
@arose
Copy link
Member

arose commented Jul 18, 2020

Yeah, that's because the rainbow color theme uses the sequence-id (also the name of the theme...) defined for polymers but that is not given in pdb format files. For reasons of side effects the pdb format readers just uses the residue number as the sequence id which leads to the problem you are observing.

arose added a commit that referenced this issue Jul 18, 2020
- leave undefined so it can be added later with hierarchy info
- see #72
@arose
Copy link
Member

arose commented Jul 18, 2020

added a fix that needs some testing, especially with multi chain .pdb file examples

@bioinsilico
Copy link
Author

Thank you Alex! I will test that

@arose
Copy link
Member

arose commented Sep 10, 2020

Hey @bioinsilico, does this work for you now?

@bioinsilico
Copy link
Author

@arose Yes, this worked in our tests, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants