This repository has been archived by the owner on Mar 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Rewrite interface of hartree_fock function #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mfherbst
commented
Sep 12, 2017
•
edited
edited
- More general parameter map structure
- High-level interface using kwargs and low-level interface using an ScfParameters object
- Update examples to new interface
- Reimplement forwarding parameters to output state
- Test re-running calculation from the forwarded parameters
- Reimplement guess from previous calculation
- Reimplement writing parameters to hdf5 and yaml archive
This class is now called HfParameters and is much less bloaty. The input handling is done directly with pointers and numpy arrays instead of the std::vector<double> structures and similar. This commit breaks the python interface.
Make the class much more general such that it could be easily applied to Kohn-Sham problems as well
Easily transfer scf solutions between a description of numpy arrays and a description of lazyten::Eigensoltion which is used on the c++ sdie.
Makes it easy to obtain and use virtual/occupied subspaces of tensors running over scf orbital indices.
Numpy representers work and numpy strip_special function
Note that the tests still fail.
mfherbst
force-pushed
the
dev-new-python-interface
branch
from
October 8, 2017 21:53
c1b9e5e
to
ace3bc6
Compare
This way the test does not fail in case the coefficients which are found by the routine are not exactly the ones in the reference but related by an unitary rotation.
mfherbst
force-pushed
the
dev-new-python-interface
branch
from
October 9, 2017 12:09
082fc56
to
49085d7
Compare
mfherbst
force-pushed
the
dev-new-python-interface
branch
from
October 9, 2017 12:15
49085d7
to
0da9165
Compare
mfherbst
force-pushed
the
dev-new-python-interface
branch
from
October 9, 2017 12:55
e1e854a
to
0a13140
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.