Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aeria #1218

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
8 changes: 1 addition & 7 deletions cases/aeria.ts
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
import { silentValidator } from '@aeriajs/validation';
import { createCase } from '../benchmarks';

/*
* This import was switched to a require() because otherwise
* ts compiler would reach node_modules/@aeriajs/**, and compilation
* would fail because aeria uses a newer Typescript version
*/
const { silentValidator } = require('@aeriajs/validation');

const schema = <const>{
type: 'object',
properties: {
Expand Down
24 changes: 12 additions & 12 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
"ts-json-validator": "0.7.1",
"ts-node": "10.9.1",
"ts-runtime-checks": "0.4.1",
"typescript": "5.1.6",
"typia": "5.3.3",
"typescript": "5.4",
"typia": "5.5.3",
"unknownutil": "3.11.0",
"valibot": "0.21.0",
"vality": "6.3.3",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "tsconfigs/nodejs-module",
"extends": "./node_modules/tsconfigs/nodejs-module.json",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what does this change? did the old stop working in the new ts version?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. tsc would still run fine but npm run test would fail with:

TSError: ⨯ Unable to compile TypeScript:
error TS6053: File 'tsconfigs/nodejs-module' not found.

A bit weird indeed.

"compilerOptions": {
"lib": ["ES2015", "DOM"],
"target": "ES2015",
Expand Down
Loading