-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add aeria #1218
Open
minenwerfer
wants to merge
10
commits into
moltar:master
Choose a base branch
from
minenwerfer:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,840
−11,442
Open
feat: add aeria #1218
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
db7bf0a
feat: add aeria
minenwerfer defa256
fix aeria version and lint
minenwerfer f53593b
restore files in docs/results/, add aeria in README.md
minenwerfer ec84e8e
chore: add skipLibCheck: rue to tsconfig.json
minenwerfer 5d7baec
refactor: revert changes to tsconfig, use a dynamic require() to work…
minenwerfer 69fc16f
chore: bump `@aeriajs/validation` to 0.0.7
minenwerfer b6a4bde
chore: bump `typescript` and `typia`
minenwerfer 98a88d6
chore: remove package-lock.json
minenwerfer 89713a2
chore: package-lock.json
minenwerfer dbd37c4
fix: declare purposefully missing aeria dependencies
minenwerfer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, what does this change? did the old stop working in the new ts version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
tsc
would still run fine butnpm run test
would fail with:A bit weird indeed.