benchmark each module in their own node process #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moltar
requested changes
May 17, 2022
Merged
|
Very excited to see the "real" ones result 👀👏🏻 |
|
Oops, sorry, I've introduced a small conflict by merging #865 |
The node/no-published-import did not fail before because the .gitignore in the spectypes directory. Using the global .gitignore triggers it through - looks like a bug in eslint? Nevertheless for this project the rule is of no use.
hoeck
force-pushed
the
isolated-benchmark-runs
branch
from
7a568b4
to
d58be44
Compare
|
@moltar fixed all linter issues (atm. I am not using Eslint at work so I always forget about it on other projects 😅) Rebased, added a message linking to this issue and disabled an Eslint rule that was complaining about the way spectypes are imported. |
hoeck
force-pushed
the
isolated-benchmark-runs
branch
from
5eb399c
to
ea914ab
Compare
|
Sorry for the noise, I should have used a Github markdown previewer 😑 😀. |
moltar
approved these changes
May 23, 2022
|
Sweet @hoeck!
Do you use something else? |
|
@hoeck Good work :) +1 |
No, we're only using prettier in our team of two. There have been always more important tasks than fixing the old and ignored tslint setup 😄 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trying to fix #864