Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of crack #23

Open
marcandre opened this issue Dec 21, 2018 · 1 comment
Open

Get rid of crack #23

marcandre opened this issue Dec 21, 2018 · 1 comment

Comments

@marcandre
Copy link
Contributor

I'm running into this issue

Short story: crack is a bad dependency to have. It's basically abandonware. The last official release (2015) uses the safe_yaml gem, which is also abandonware. Note that this has been fixed more than 2 years ago, but they haven't bothered to make a release with that bugfix.

Making releases has basically no cost. Not releasing versions after bugs are fixed is a mistake.

Note also that the same_yaml gem also fixed the issue more than a year ago. But hasn't released it. There's just no excuse in not releasing versions after changes.

@zverok
Copy link
Contributor

zverok commented Dec 21, 2018

Yeah, makes sense.
It was added at the point of 0.0.1 (aka The Prototype) "just to play with", obviously hard dependency on abandonware is not an acceptable thing.
Probably I'll drop the xml: true feature completely for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants