Updates to temperature - binned heat budget diagnostics #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage is now consistent with neutral_density_omega and neutral_density_potrho usage in ocean_density.F90. Also, corrected .out messages and neutral_rho diagnostic label + units when this option is active.
|
This is very useful diagnostic code. Please test that nothing is broken and then I suggest it be merged as soon as cleared. |
|
Thanks Steve. I've tested it in MOM-SIS025 and ACCESS-OM2, and also just now in the wind-driven gyre test case. No problems. Happy for someone else to check as well if needed. |
|
I just merged this code into the main branch. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits update the previous neutrho_is_temp changes (#202) to:
1. Fix a bug in the GM temperature-binned diagnostic
2. Add a diagnostic to bin the mixdownslope term (on in ACCESS-OM2)
3. Clean up the neutral_rho_equal_theta option in ocean_density to be consistent with neutral_rho_potrho option and provide proper messages to mom.out
Has been tested on a MOM-SIS 1/4-degree config and the new ACCESS-OM2-1degree (with yatm).
Note that I have not yet included diagnostics to bin the following heat budget terms:
temp_sigma_diff, temp_xlandmix, temp_xlandinsert, temp_runoffmix, temp_calvingmix, geo_heat
These are not active in the configurations I am using. I'm happy to do this if anyone would like these terms in the future, just point me at a test case.
Note also that this pull request reverts some unintentional changes to the neutral_rho_equal_theta option (now neutral_density_theta) introduced by APE changes #210 (#211).