Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix range of squared diagnostic tracer outputs #332

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

rmholmes
Copy link
Contributor

Avoids out of range errors (because the range used previously for these variables was that for the unsquared raw tracer) which create very large standard .err files...

Currently testing in OMIP run but don't anticipate any issues...

@russfiedler
Copy link
Collaborator

russfiedler commented Oct 16, 2020

Wouldn't these be more natural as [0.0,range_array(2)**2] or [0.0,maxval(range_array**2)] to be consistent with the standard diagnostics. It (possibly) allows for short integer packing.

@rmholmes
Copy link
Contributor Author

Possibly yes, I just copied what had been done with the prognostic squared diagnostics. So if we want to make this change it would be best to make it everywhere...

@aekiss
Copy link
Collaborator

aekiss commented Oct 23, 2020

I'm merging this as an urgent bugfix. We can finesse it later - I've made an issue so we don't forget: #334

@aekiss aekiss merged commit 5aec067 into mom-ocean:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants