Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uninitialised variables check to CI build #361

Merged
merged 44 commits into from
Feb 10, 2022
Merged

Conversation

aidanheerdegen
Copy link
Contributor

Adding in the initialised variable checks to CI build.

Should have added this in #349

@aidanheerdegen
Copy link
Contributor Author

@russfiedler can you take a look and give me a sanity check before I merge?

Summary: this is a PR which adds bounds checking to the compile step. In order for this to work it requires the -Werror directive, which throws up all sorts of unrelated errors.

I started down the road of trying to fix all the old legacy code in the atmosphere code, but in the end reverted most of that and omit ESM2M, CM2M and ICCM from the --debug` build.

In the end most of the changes are superificial: just removing non-standard labels from #endif preprocessor directives.

@aidanheerdegen
Copy link
Contributor Author

I have run a repro test (tests a 1 degree and 0.25 degree model)

https://accessdev.nci.org.au/jenkins/blue/organizations/jenkins/mom-ocean.org%2FMOM5_PR/detail/MOM5_PR/15/pipeline/

@aidanheerdegen
Copy link
Contributor Author

Will assume silence is assent and merge

@aekiss
Copy link
Collaborator

aekiss commented Feb 10, 2022

Thanks for all your work on this.

@aidanheerdegen aidanheerdegen merged commit b68f137 into master Feb 10, 2022
@aidanheerdegen aidanheerdegen deleted the initchecks branch February 10, 2022 05:41
@aidanheerdegen aidanheerdegen restored the initchecks branch February 10, 2022 05:53
@aidanheerdegen aidanheerdegen deleted the initchecks branch October 17, 2022 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants