Feature request: toRelative multiple units

[marcobiedermann]

It would be great to specify multiple units for toRelative() to receive a more precise result if the date is less than 24 hours.

toRelative({ units: ['days', 'hours' ]})

> 24 hours

in 2 days

---

< 24 hours

in 10 hours

[GillesDebunne]

Indeed sounds useful.

Have you tried specifying no unit at all? In that case, the method picks the 'best' unit (i.e. largest non zero unit), which should indeed return in 2 days or in 10 hours I think.

[marcobiedermann]

@GillesDebunne

Yes, I've tried but it always falls back to date or today / yesterday if it is within the next / last 24 hours

[GillesDebunne]

From the unit tests :

const base = DateTime.fromObject({ year: 1983, month: 10, day: 14 });
  expect(base.plus({ minutes: 1 }).toRelative({ base })).toBe("in 1 minute");
  expect(base.plus({ minutes: 5 }).toRelative({ base })).toBe("in 5 minutes");
  expect(base.plus({ minutes: 65 }).toRelative({ base })).toBe("in 1 hour");
  expect(base.plus({ minutes: 165 }).toRelative({ base })).toBe("in 2 hours");
  expect(base.plus({ hours: 23 }).toRelative({ base })).toBe("in 23 hours");
  expect(base.plus({ hours: 24 }).toRelative({ base })).toBe("in 1 day");

What you describe looks more like toRelativeCalendar.

[SidharthRaveendran]

why does toRelative round down the highest unit whereas toRelativeCalendar rounds up?

[GillesDebunne]

The difference between these two methods is that toRelative deals with datetime whereas toRelativeCalendar handles dates only. Hence the day granularity for the latter.

[andreialecu]

I opened a PR at #926 to implement this.