Testing/sauce labs integration #1374
Conversation
|
TODO:
|
|
Looks good! Concerning the terminal issue, you should probably change the reporter to something more Travis friendly like the |
|
This is so awesome. Is this ready to merge? |
|
If you're happy I'll merge it. I want to take one last look.
|
| // it doesn't need Z at the end. | ||
| var d = new Date(leftZeroFill(year, 6, true) + '-01-01').getUTCDay(), | ||
| daysToAdd, dayOfYear; | ||
| var d = makeUTCDate(year, 0, 1).getUTCDay(), daysToAdd, dayOfYear; |
There was a problem hiding this comment.
what happened here? Seems like a rollback?
There was a problem hiding this comment.
Ie doesn't parse long years at all. When I wrote the original code the
makeDate functions didn't work with small years (or for some unknown stupid
reason) I wrote the string parsing inside... Stupid idea.
On Dec 27, 2013 9:12 PM, "Isaac Cambron" notifications@github.com wrote:
In moment.js:
@@ -1497,11 +1497,7 @@
//http://en.wikipedia.org/wiki/ISO_week_date#Calculating_a_date_given_the_year.2C_week_number_and_weekday function dayOfYearFromWeeks(year, week, weekday, firstDayOfWeekOfYear, firstDayOfWeek) {
// The only solid way to create an iso date from year is to use// a string format (Date.UTC handles only years > 1900). Don't ask why// it doesn't need Z at the end.var d = new Date(leftZeroFill(year, 6, true) + '-01-01').getUTCDay(),daysToAdd, dayOfYear;var d = makeUTCDate(year, 0, 1).getUTCDay(), daysToAdd, dayOfYear;what happened here?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1374/files#r8575464
.
|
OK, I'm happy with this. Good work! |
To use sauce testing from a dev machine please contact ichernev on github.
|
We have a bug with weekYear/week/weekday setters. Lets fight it in another issue/PR. |
Testing/sauce labs integration @changelog @section misc @description Run tests on multiple browser/os combos via SauceLabs and Travis
This is a continuation of #1301
@alexstrat any comments? I already used this setup to test the latest release, so in terms of usability -- it works (haven't tested the travis build hooks though).
A few tests fail right now (IE8 and Safari), these are being worked on, so ignore them :)