Change object construction to prevent Chrome v32 crashing. #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suspected JS execution optimizations in v32 is causing the browser to throw "Aw, Snap". See #1423
|
Thank you for troubleshooting and patching this. Can you please submit and link a chrome bug for this? |
ichernev
added a commit
that referenced
this pull request
Jan 22, 2014
Change object construction to prevent Chrome v32 crashing. @changelog @section bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting reports that our website was crashing in Chrome. We were able to pinpoint it to moment.
Changing the config from a literal object to setting properties is ugly, but resolves the issue for us in production. Given how frequently Chrome is updated I suspect we'll be able to revert it once it's fixed upstream.
See #1423.