zone setter can now skip adjusting the hour #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you change the zone you'd expect the time to remain the same, but if you're doing something low-level you might want just the zone offset to change. Add a second argument to zone that would allow the caller to disable adjusting the hour when setting a zone.
ichernev
added a commit
to ichernev/moment
that referenced
this pull request
Feb 6, 2014
This is related to moment#1468
|
For some reason, I thought we'd already done this. |
icambron
added a commit
that referenced
this pull request
Feb 6, 2014
@changelog @section enhancement @description zone setter can now skip adjusting the hour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you change the zone you'd expect the time to remain the same, but if
you're doing something low-level you might want just the zone offset to change.
Add a second argument to zone that would allow the caller to disable adjusting
the hour when setting a zone.
I'll make a corresponding PR in the moment-timezone repo.