New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zone setter can now skip adjusting the hour #1468

Merged
merged 1 commit into from Feb 6, 2014

Conversation

Projects
None yet
2 participants
@ichernev
Contributor

ichernev commented Feb 6, 2014

When you change the zone you'd expect the time to remain the same, but if
you're doing something low-level you might want just the zone offset to change.

Add a second argument to zone that would allow the caller to disable adjusting
the hour when setting a zone.

I'll make a corresponding PR in the moment-timezone repo.

zone setter can now skip adjusting the hour
When you change the zone you'd expect the time to remain the same, but if
you're doing something low-level you might want just the zone offset to change.

Add a second argument to zone that would allow the caller to disable adjusting
the hour when setting a zone.

ichernev added a commit to ichernev/moment that referenced this pull request Feb 6, 2014

@icambron

This comment has been minimized.

Member

icambron commented Feb 6, 2014

For some reason, I thought we'd already done this.

icambron added a commit that referenced this pull request Feb 6, 2014

Merge pull request #1468 from ichernev/feature/allow-zone-skip-adjust
@changelog
@Section enhancement
@description zone setter can now skip adjusting the hour

@icambron icambron merged commit c70beab into moment:develop Feb 6, 2014

1 check passed

default The Travis CI build passed
Details

@theurere theurere referenced this pull request Jul 1, 2014

Merged

Update moment.js to 2.7.0 #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment