Fix moment diff across dst in weird cases #1848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
moment diff across dst was sometimes failing because of a floating point rounding. Just make sure to first do additions/subtractions and then division.
ichernev
force-pushed
the
bugfix/fix-month-diff
branch
from
ee85ed8
to
c3ed7e2
Compare
ichernev
added a commit
that referenced
this pull request
Sep 5, 2014
Fix moment diff across dst in weird cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moment diff across dst was sometimes failing because of a floating point
rounding. Just make sure to first do additions/subtractions and then division.
fixes #1842