Duration asMilliseconds regression from v2.6.0 to v2.8.1

[mjgallag]

moment.duration({minutes: 17, seconds: 25, milliseconds: 900}).asMilliseconds();
1045900 //v2.60
1045899.9999999999 //v2.8.1

[ichernev]

You're right. The regression is in 2.7.0 to 2.8.1. We reimplemented duration, and evidently this thing slipped :)

[jsmreese]

The breaking change came in version 2.8.0, and it affects the .as() and .asUnits() methods for the units 'milliseconds', 'seconds', and 'minutes'.

The updated .as() implementation leads to floating point errors for those units.

Simple tests, that should be true:

moment.duration(1, "milliseconds").as("milliseconds") === 1;
moment.duration(3, "seconds").as("seconds") === 3;
moment.duration(13, "minutes").as("minutes") === 13;

[ichernev]

Closing in favor of #1883