Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing locale files en and en-US #2081

Closed
danieljsinclair opened this issue Dec 4, 2014 · 3 comments
Closed

Missing locale files en and en-US #2081

danieljsinclair opened this issue Dec 4, 2014 · 3 comments

Comments

@danieljsinclair
Copy link

I appreciate this may be the default language, but it would be convenient if the source had reference files (even empty ones) for these two locales.

At best one could expect a 404 for some implementations that dynamically switch locales, but in my case I'm having to create a list of the locale subset supported by both AngularJS and MomentJS - unfortunately, "en" and "en-US" don't make the of course.

How about a couple of blank files with the simple text /* default */ ?

@ichernev
Copy link
Contributor

I agree its not symmetrical, but I don't think we'll ever put 'en' and 'en-US' separately. Also I don't think putting an empty file is a good idea -- it just happens that your algorithm uses filenames, somebody else's might try to detect defineLocale calls ...

Just add 'en-US' to the list of locales (you're writing the algo). en is just an alias for en-US.

@codemole986
Copy link

Where I can check default configuration set for "en" locale?

@phy25
Copy link

phy25 commented Jan 27, 2018

@codemole986 lib/locale/base-config.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants