load locale dynamically only when not en-us #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgbkrk
commented
Sep 25, 2017
| } | ||
| var uiLang = _uiLang(); | ||
|
|
||
| if (uiLang !== 'en' && uiLang !== 'en-us') { |
There was a problem hiding this comment.
The primary change here, with comment below
blink1073
approved these changes
Sep 25, 2017
|
Since this is pretty much passing, I'm thinking I need to take a second look at how I'm doing the vdom mimetype in #2840. O____o |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to investigate failing tests on master, I noticed that there were errors because moment doesn't have a separate locale file for
enoren-us. They keep it as a default per moment/moment#2081.Since the whitespace was misleading in this file (I thought some of these functions were inside each other until I cleaned it up), I ran
prettierover it.