Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Korean month parsing #240

Closed
timrwood opened this issue Mar 30, 2012 · 2 comments
Closed

Add unit tests for Korean month parsing #240

timrwood opened this issue Mar 30, 2012 · 2 comments
Labels

Comments

@timrwood
Copy link
Member

No description provided.

@rockymeza
Copy link
Contributor

The only way I see to make these tests pass is to change the inputCharacters regex to this:

inputCharacters = /(\\)?([0-9]{1,2}\uC6D4|[0-9]+|([a-zA-Z\u00A0-\uD7FF\uF900-\uFDCF\uFDF0-\uFFEF])+|([\+\-]\d\d:?\d\d))/gi,

@timrwood, It sort of feels like a hack. What do you think?

rockymeza pushed a commit that referenced this issue Apr 2, 2012
@timrwood
Copy link
Member Author

This is fixed with the new parser. Thanks Rocky for the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants