[locale] ko: Update ordinal format #3839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fbonzon
reviewed
Mar 16, 2017
locale/ko.js
Outdated
| @@ -49,8 +49,22 @@ var ko = moment.defineLocale('ko', { | |||
| y : '일 년', | |||
| yy : '%d년' | |||
| }, | |||
| ordinalParse : /\d{1,2}일/, | |||
There was a problem hiding this comment.
Please rebase from the HEAD of the develop branch. This was renamed dayOfMonthOrdinalParse 5 days ago.
almost copied from zh-cn.js
|
@fbonzon sorry for late check. i've updated it. |
|
@FourwingsY you need to update |
ichernev
changed the title
|
@ichernev done. |
|
@kyungw00k what do you think? |
|
@FourwingsY can you also undo the changes to |
|
@ichernev 👌 |
its autogenerated
|
yup |
|
Merged in eef541e |
ichernev
added a commit
that referenced
this pull request
Aug 9, 2017
[locale] ko: Update ordinal format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
almost copied from zh-cn.js