Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] Add strict parsing month name tests for all locales #4832

Closed

Conversation

joelmheim
Copy link
Contributor

Have added strict parsing tests to all locales test files. Most are running ok, but the following are failing:

  • ar (all strict parsing tests fail)
  • ar-ly (all strict parsing tests fail)
  • bo (only 'MMM', only month 1 (jan))
  • fy (only 'MMM', only month 5 (may))
  • gu (only 'MMM', only month 12 (dec))
  • ka (all tests fail. Reason given in Travis CI failing due to Georgian locale on node 10.7+ #4762)
  • kn (only month 9 (sep))
  • nl (only 'MMM', only month 5 (may))
  • nl-be (only 'MMM', only month 5 (may))
  • pl (only 'MMM', all months)
  • sk (only 'MMM', all months)
  • sl (only 'MMM', only month 5 (may))
  • tr (only 'MMMM' uppercase, only months 5, 11 and 12)

These tests are commented out (also removing some tests that will run fine). I suggest that we create separate issues for the failing tests and enlist help from people with knowledge of the different locales to fix these once and for all. It is hard for me to tell whether they fail because of parsing logic in moment, changes in unicode parsing or wrong test definition (or something else that I have not thought about).

At least this brings us a bit further in checking that strict parsing works for all locales.

@joelmheim joelmheim changed the title Added strict parsing tests for all locales. Commented out all failing tests. [tests] Added strict parsing tests for all locales. Commented out all failing tests. Oct 26, 2018
@joelmheim
Copy link
Contributor Author

Updated title.

@ichernev
Copy link
Contributor

Merged in e0d031f

@ichernev ichernev changed the title [tests] Added strict parsing tests for all locales. Commented out all failing tests. [tests] Add strict parsing month name tests for all locales Apr 27, 2020
@ichernev ichernev closed this Apr 27, 2020
ichernev added a commit that referenced this pull request Apr 27, 2020
[tests] Add strict parsing month name tests for all locales
@ichernev
Copy link
Contributor

OK, I just had to fix 90 merge conflicts but this is now MERGED!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants