Allow creation of moment+langs.js #1057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Represents a continuation of #973 (didn't mean to create a new pull request specifically, but all the old work was made irrelevant anyway, and apparently github auto-closes pull requests if you delete the branch. Go figure).
moment+langs.js
is a version of moment.js, prepackaged with all languages. Can specify--embed_languages=ar,br
to createmin/moment+customlangs.js
with just those two languages (went with this overmin/moment+ar+br.js
since it was easier to configure; could switch over if that's still your wish). Also didn't indent the lang closures, since I think the file is readable as is; again, could indent if you guys want.If you're wondering about
lang/da.js
, that was just a minor tweak so that it would match the replacement regex and pass jshint. And the error message is mostly in reference tolang/hr.js
, which at this time has the old node-require instead of a UMD wrapper, giving example output of:Warning: all language files must use the common UMD wrapper pattern. Failed language file: lang/hr.js