New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use HTML entities in Welsh translations #1421

Merged
merged 1 commit into from Jan 17, 2014

Conversation

Projects
None yet
4 participants
@BYK
Contributor

BYK commented Jan 16, 2014

Since this is a JavaScript library, we may not always use the produced strings in HTML directly. This changes the HTML entity used for "à" in Welsh translations to, well, "à".

@icambron

This comment has been minimized.

Member

icambron commented Jan 16, 2014

This is definitely a good change, but can you fix the test too? See https://github.com/moment/moment/blob/develop/test/lang/cy.js#L177

@BYK

This comment has been minimized.

Contributor

BYK commented Jan 16, 2014

Aaah, my bad. I forgot translations had tests too. I'm even more confident about moment.js now :)

Don't use HTML entities in Welsh translations
Since this is a JavaScript library, we may not always use the produced strings in HTML directly. This changes the HTML entity used for "à" in Welsh translations to, well, "à".
@BYK

This comment has been minimized.

Contributor

BYK commented Jan 16, 2014

Done! :)

ichernev added a commit that referenced this pull request Jan 17, 2014

Merge pull request #1421 from BYK/patch-1
Don't use HTML entities in Welsh translations

@changelog
@Section bugfix
@description remove html entities from welsh

@ichernev ichernev merged commit a80ee78 into moment:develop Jan 17, 2014

1 check passed

default The Travis CI build passed
Details
@robgallen

This comment has been minimized.

Contributor

robgallen commented May 15, 2014

While this change was made with good intentions, & #244 ; is ô not à.

@BYK BYK deleted the BYK:patch-1 branch May 15, 2014

@BYK

This comment has been minimized.

Contributor

BYK commented May 15, 2014

@robgallen sorry, I don't know what was I smoking! :( Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment