Don't use HTML entities in Welsh translations #1421

Merged
merged 1 commit into from Jan 17, 2014

Projects

None yet

4 participants

@BYK

Since this is a JavaScript library, we may not always use the produced strings in HTML directly. This changes the HTML entity used for "à" in Welsh translations to, well, "à".

@icambron
Moment.js member

This is definitely a good change, but can you fix the test too? See https://github.com/moment/moment/blob/develop/test/lang/cy.js#L177

@BYK

Aaah, my bad. I forgot translations had tests too. I'm even more confident about moment.js now :)

@BYK BYK Don't use HTML entities in Welsh translations
Since this is a JavaScript library, we may not always use the produced strings in HTML directly. This changes the HTML entity used for "à" in Welsh translations to, well, "à".
abfb645
@BYK

Done! :)

@ichernev ichernev merged commit a80ee78 into moment:develop Jan 17, 2014

1 check passed

Details default The Travis CI build passed
@robgallen

While this change was made with good intentions, & #244 ; is ô not à.

@BYK BYK deleted the BYK:patch-1 branch May 15, 2014
@BYK

@robgallen sorry, I don't know what was I smoking! :( Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment