Don't use HTML entities in Welsh translations #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is definitely a good change, but can you fix the test too? See https://github.com/moment/moment/blob/develop/test/lang/cy.js#L177 |
|
Aaah, my bad. I forgot translations had tests too. I'm even more confident about moment.js now :) |
Since this is a JavaScript library, we may not always use the produced strings in HTML directly. This changes the HTML entity used for "à" in Welsh translations to, well, "à".
|
Done! :) |
ichernev
added a commit
that referenced
this pull request
Jan 17, 2014
Don't use HTML entities in Welsh translations @changelog @section bugfix @description remove html entities from welsh
|
While this change was made with good intentions, & #244 ; is ô not à. |
|
@robgallen sorry, I don't know what was I smoking! :( Thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is a JavaScript library, we may not always use the produced strings in HTML directly. This changes the HTML entity used for "à" in Welsh translations to, well, "à".