New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frisian (fy) language file with unit test #2104

Closed
wants to merge 3 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@RobinvanderVliet

RobinvanderVliet commented Dec 16, 2014

I translated the language file to Frisian (fy: Frysk), a language spoken in the northern part of the Netherlands.

@Menelion

View changes

locale/fy.js Outdated
var monthsShortWithDots = 'jan._feb._mrt._apr._mai_jun._jul._aug._sep._okt._nov._des.'.split('_'),
monthsShortWithoutDots = 'jan_feb_mrt_apr_mai_jun_jul_aug_sep_okt_nov_des'.split('_');
return moment.defineLocale('nl', {

This comment has been minimized.

@Menelion

Menelion Dec 16, 2014

Shouldn't it be fy?

This comment has been minimized.

@RobinvanderVliet

RobinvanderVliet Dec 16, 2014

Just noticed it before I saw your comment, changed it already. 😄

@RobinvanderVliet

This comment has been minimized.

RobinvanderVliet commented Dec 19, 2014

@ichernev

This comment has been minimized.

Contributor

ichernev commented Dec 22, 2014

Looks good. I'll merge it in next release.

@ichernev ichernev added this to the 2.9 milestone Dec 22, 2014

@RobinvanderVliet

This comment has been minimized.

RobinvanderVliet commented Dec 24, 2014

@ichernev Thanks!
Should I also add the language to "component.json" or do you do this when you merge it?

@ichernev

This comment has been minimized.

Contributor

ichernev commented Dec 24, 2014

Don't worry, we have a procedure in place for that.
Merged in 26f36bb

@ichernev ichernev closed this Dec 24, 2014

ichernev added a commit that referenced this pull request Dec 28, 2014

Merge pull request #2104 from robin0van0der0v:patch-1
Frisian (fy) language file with unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment