Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frisian (fy) language file with unit test #2104

Closed
wants to merge 3 commits into from
Closed

Frisian (fy) language file with unit test #2104

wants to merge 3 commits into from

Conversation

RobinvanderVliet
Copy link

I translated the language file to Frisian (fy: Frysk), a language spoken in the northern part of the Netherlands.

var monthsShortWithDots = 'jan._feb._mrt._apr._mai_jun._jul._aug._sep._okt._nov._des.'.split('_'),
monthsShortWithoutDots = 'jan_feb_mrt_apr_mai_jun_jul_aug_sep_okt_nov_des'.split('_');

return moment.defineLocale('nl', {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be fy?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed it before I saw your comment, changed it already. 😄

@RobinvanderVliet
Copy link
Author

@ichernev What do you think about this pull request, is it correct?
Some sources: https://fy.wikipedia.org/wiki/Tiid https://fy.wikipedia.org/wiki/Moanne_(tiid) https://fy.wikipedia.org/wiki/Wike

@ichernev
Copy link
Contributor

Looks good. I'll merge it in next release.

@ichernev ichernev added this to the 2.9 milestone Dec 22, 2014
@RobinvanderVliet
Copy link
Author

@ichernev Thanks!
Should I also add the language to "component.json" or do you do this when you merge it?

@ichernev
Copy link
Contributor

Don't worry, we have a procedure in place for that.
Merged in 26f36bb

@ichernev ichernev closed this Dec 24, 2014
ichernev added a commit that referenced this pull request Dec 28, 2014
Frisian (fy) language file with unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants