Fix building tasks for moment-with-locales.js
and moment-with-locales.custom.js
#2393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2367 moment-with-locales.custom.js uses last defined locale by default
moment-with-locales.js
andmoment-with-locales.custom.js
were default to "en".See grunt task
embedLocales
:Adding it back to transpiling task seems the right thing to do.
custom locale building was broken
In current built
moment-with-locales.custom.js
:this line
which
moment
is actually undefined, and should be replaced with the matches from the regex,and thus become