Expect 0 assertions to fix #2382 #2473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that while this does fix #2382, I don't really like that we are ignoring the test. We should probably update it to have the expected behavior for this browser configuration, rather than exiting early. |
|
I'm fine ignoring the test for browsers that are wrong. If they fix the browser it will start working again, so I don't see an issue here. |
|
Well for one thing, the date that is tested is just for the US. Other time zones may exhibit this bug on other dates. |
|
I agree its not perfect. We had a function to detect DST and use it -- I think we should do that more often (and cache the results, because they are expensive). I'm merging this as-is. |
ichernev
added a commit
that referenced
this pull request
Jul 13, 2015
Expect 0 assertions to fix #2382
|
Merged in 27e22be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes QUnit complaining about exiting test early.